react-datetime icon indicating copy to clipboard operation
react-datetime copied to clipboard

Forgotten 'console.log' in the code

Open bryandidur opened this issue 4 years ago • 7 comments

I'm Submitting a ...

[x] Bug report
[ ] Feature request
[ ] Support request

Steps to Reproduce

  1. Clicking on the datetime input logs a "CLICKING 2!" message in the console.

Expected Results

No debug logs.

Actual Results

Logs a "CLICKING 2!" message in the developer console.

Minimal Reproduction of the Problem

See this sandbox to inspect the debug message https://codesandbox.io/s/lively-worker-vsqu1?file=/src/App.js

Other Information (e.g. stacktraces, related issues, suggestions how to fix)

None

bryandidur avatar Oct 14 '20 14:10 bryandidur

Glad I'm not the only one who sometimes forgets console.logs in production code!

SachaG avatar Oct 22 '20 04:10 SachaG

I just checked out the file DateTime.js, the source of the log and I didn't find the log statement! Am I doing something wrong?

Ashirogi-Muto avatar Nov 05 '20 02:11 Ashirogi-Muto

I don't know. But the log exists, as you can see in the sandbox.

bryandidur avatar Nov 07 '20 00:11 bryandidur

I am using this library in my company's product which is built in React and yes I can see the log there too!

Ashirogi-Muto avatar Nov 07 '20 00:11 Ashirogi-Muto

It seems to be in the minified version sitting in the dist directory, I think it needs re-building from the current source as DateTime.js doesn't have that line now

ali-wells avatar Nov 18 '20 15:11 ali-wells

Should probably add eslint rule https://eslint.org/docs/rules/no-console

johnhunter avatar Feb 04 '21 09:02 johnhunter

Do we have an ETA on when this will be fixed?

NoPhaseNoKill avatar Mar 25 '21 02:03 NoPhaseNoKill