John Hooks
John Hooks
@bkiac I couldn't find any reason that the `value` parameters of the `Formatter` were optional. PR #725 makes them required. @sarahdayan is that alright with you? Because if `value` is...
I support combining the calculators and core into `dinero.js`.
I would recommend using tsconfig paths to reduce the need for relative paths.
It would be nice if something like this worked. It does show an error in the editor and doesn't pass the script `test:types`, but `test` passes because Jest strips all...
I learned there is an interesting feature of `api-extractor` that can help with this, it typically throws an error if the `*.api.md` doesn't match the code base, though in local...
@erikyo I don't have any experience with WordPress localization, do you know the basics so we can get started? Because as soon as we get the db test data filled...
@erikyo because of how we decided to do the notificaton messages with `title_key` and `message_key`, and channels have `name_key` and `description_key`, we need to manually add entries in order for...
Summary of thoughts from Discussion #113. I believe the translation of a notification has to happen when it is emitted and stored in the database for the following reasons: -...
Perhaps this system shouldn’t be trying to tackle translations. It should provide a way for plugins to emit notifications. Leave providing translations to the plugins or new developments into how...
@erkiyo and I had a conversation about trying to use the [WordPress Playground](https://developer.wordpress.org/playground/) to create a easy to share demo of the plugin. The big bonus being able to auto...