John Hooks

Results 80 comments of John Hooks

Though, now that I look at it, that pushes the app out of the free tier which is less than desirable for an example. My specific issue occurred in the...

Just to make sure, I ran it again. It failed multiple times scaled to 256MB, but then succeeded. This is the fly.io monitor log from one of the failures ```sh...

You could... ```js import * as currencies from '@dinero.js/currencies' const key = 'USD' // or whatever if (key in currencies) { const currency = currencies[key] // do what ever you...

I just created [PR #665](https://github.com/dinerojs/dinero.js/pull/665) it moves the currencies packages to currencies-number. If @sarahdayan thinks this is the way forward, @reckter could you modify this PR to create a new...

@sarahdayan I read through the `toUnits` function and it seems like a much more useful function than the current function `toUnit`. What help do you need to push this forward?

@sarahdayan I've started reading through it. So far, I like the concept of `toDecimal` and `toUnits`. Returning a string value from `toDecimal` makes sense to me.

@bel0v this is being considered in [PR #309](https://github.com/dinerojs/dinero.js/pull/309) The new [toUnits](https://github.com/dinerojs/dinero.js/blob/45b5e671f70c07fc2588613006e6919fc95808d2/packages/dinero.js/src/api/toUnits.ts) function will return a tuple of `[major, minor]`. So it would be trivial to get just the sub units....

> What's this part for? If we can have a JSON file instead (I think it's possible) which we can then leverage in the site with MDX, it's better. @sarahdayan,...

I have added `api-extractor` to core, the most interesting for review is the `packages/core/etc/core.api.md` file. Its for tracking api changes, alert for errors, and show what is public but isn't...