John Hooks
John Hooks
@sarahdayan awesome! This is my first big commit to an open source repo, I'm pumped!
@sarahdayan I think some where in the rebase to make things work I delete the yarn.lock file! I though it was going to keep the original and just get rid...
I was just working to try to do that, just checking so I make sure I know how, I would checkout the lock file from the commit right before mine...
@sarahdayan I found something odd while porting this change to my Deno module, and it doesn't come up in this repo because test files aren't type checked the same as...
If I provide a custom transform function it resolves the type issue. It returns `DineroSnapshot` rather than `unknown`. ```ts const snapshot = toSnapshot(transformScale(d, 4), ({value}) => value); ``` The type...
I have a grasp of the issue, but still don't know how to resolve it. Providing a default transformer creates a type issue, because `TOutput` could be provided as a...
I still haven't found the answer, though it's making me question why `toDecimal`, `toSnapshot`, `toUnits` need a transformer. Not because I'm having an issue with the types, but because I...
@sarahdayan I put together my suggested changes in this branch, I don't believe I can push it to this remote branch. It only modifies the source code. If you approve...
@sarahdayan that is perfect and I learned something new! It was really tripping my mind. It had to be possible, but I couldn't find good information about how a generic...
I was thinking of `toUnits` as less of a format function and more as a utility to split an amount into currency divisions. It's used internally by `toDecimal`. But I...