johnfb

close_loop coroutine instantiated but never awaited in (old?) asyncio loop integration

1

I was trawling through the source code and I spotted what looks to me like a possible bug here: https://github.com/ipython/ipykernel/blob/d4a8703593cbe5d82bc955d68543dc623f5b4510/ipykernel/eventloops.py#L455 This instantiates a coroutine that never gets awaited. Calling an...

Version specification using cmake find_package with protobuf does not seem right

1

https://github.com/protocolbuffers/protobuf/blob/65ab2a2584757ac67a9858dff37b1d2e4db059e5/cmake/protobuf-config-version.cmake.in#L21 Compares the MAJOR version with the passed in version, and if it does not match says incompatible `protobuf_MAJOR_VERSION` is set here (currently set to 6) https://github.com/protocolbuffers/protobuf/blob/65ab2a2584757ac67a9858dff37b1d2e4db059e5/CMakeLists.txt#L106-L107 But the very...