John Fairhurst

Results 150 comments of John Fairhurst

Code changes look great. I think the `level` property is redundant now, can get it dynamically from the length of `documentation_path`. I appreciate the work on the styling. There's still...

Thanks! This all looks good to me now -- code nits that you can get rid of the `attr_accessor :level` line, and the changelog is missing the double-space newline. If...

👍 thanks. FYI the specs are in the `spec/integration_specs` directory -- if you do `bundle exec rake rebuild_integration_specs` then they will build with the current code and you can `git...

Realistically not going to change the URL scheme at this point. DocC does almost exactly this!

Using the config file is the right workaround: the CLI-parsing library jazzy uses does not have an escape for its comma handling.

I think the config file would go something like: ```yaml xcodebuild_arguments: - "-project" - "RxSwiftWidgets.xcodeproj" - "-scheme" - "RxSwiftWidgets-Package" - "-destination" - "platform=iOS Simulator,name=iPhone Xr 13" ```

I've thought about this a few times over the past few years -- given where we are in the docs ecosystem I think DocC is a better target for these...

Personally I'd prefer to see this as a separate PR, should be a simple change on top of the current code.

Needs a bit of libclang experimentation: libclang surfaces `objc_designated_initializer` as `CXCursor_UnexposedAttr` rather than anything specific, would need to figure out how to get the actual text.

The first attempt at 825 did fix this particular case (extension + type in same module) -- the eventual one did not -- will get there eventually though.