jazzy icon indicating copy to clipboard operation
jazzy copied to clipboard

Does custom_categories support reg expression?

Open liuxuan30 opened this issue 9 years ago • 7 comments

one question, it seems like custom_categories does not support reg expression? Let's say I have many classes with some prefix: some starts with Line, some starts with Bars:

BarChartView.swift, BarChartData.swift, LineChartView.swift, LineChartDataSet.swift

I want to group them into Line Type and Bar Type,

custom_categories:
  name: Bar Type
     children:
     - Bar*
  name: Line Type
     children:
     - Line*

It won't have any effect. Instead, I have manually list all the classes. Am I wrong?

liuxuan30 avatar Nov 29 '16 00:11 liuxuan30

Hi @liuxuan30. Thanks for reaching out. I don't believe custom_categories supports regular expressions but I'm going to rope in @jpsim. I'm pretty new so he may have more to say.

istx25 avatar Nov 29 '16 22:11 istx25

If not supported yet, I guess it would be a good feature to have.. typing multiple names are killing me

liuxuan30 avatar Nov 30 '16 01:11 liuxuan30

We'd love a PR, @liuxuan30!

jpsim avatar Dec 07 '16 20:12 jpsim

I think this would make sense to add in combination with #624. Would it be ok, to include both in the same pr?

galli-leo avatar Jun 15 '18 16:06 galli-leo

Personally I'd prefer to see this as a separate PR, should be a simple change on top of the current code.

johnfairh avatar Jun 16 '18 09:06 johnfairh

@johnfairh Yeah I quickly tested it yesterday, theoretically it can be a one line change (if we just want to assume any item is a regex).

galli-leo avatar Jun 16 '18 11:06 galli-leo

@galli-leo @johnfairh Is there any movement on this? Would love to get it working.

JUSTINMKAUFMAN avatar Jun 20 '18 21:06 JUSTINMKAUFMAN