John Macy

Results 9 comments of John Macy

ModelMultipleChoiceFilter's custom method gets called even when field is not filtered on

Continuing from #1622 Thanks Carlton. > Filters are called if the field is present in `filterset.form.cleaned_data`. > It's **not** expected though... > > > Note that the value is validated...

ModelMultipleChoiceFilter's custom method gets called even when field is not filtered on

Update: `changed_data` doesn't include submitted fields that have empty values: ``` py for name in self.form.changed_data: ``` `request.query_params` and `form.data` could include query params that are not filters (and therefore...

ModelMultipleChoiceFilter's custom method gets called even when field is not filtered on

Understood - yes, I'll do my best to write something using your test suite. In the meantime, I have an [example repo](https://github.com/johncmacy/django-filter-1625) with tests that demonstrate the issue, if that's...

ModelMultipleChoiceFilter's custom method gets called even when field is not filtered on

Hi @carltongibson, I upgraded to v24.2, and am still getting the same behavior as before.

ModelMultipleChoiceFilter's custom method gets called even when field is not filtered on

Ok, thanks for following up on this @carltongibson. It's not a deal-breaker, we can work around it.

Tracing source of QueriesDisabledError with nested serializers

Thanks for the reply - and no worries! > I would normally fix it by commenting out serializer fields and then gradually adding them back until the error is raised...

Tracing source of QueriesDisabledError with nested serializers

Here's an alternate approach. This overrides `__init__` to recursively wrap all descendant fields' `to_representation` methods with a function that logs the debug message for that field. It doesn't override DRF...

multipleOf less than 1 doesn't validate with `json_matches_schema`

Thank you both for the explanation. I understand better _why_ it's a problem, but I still think this is a bug that needs to be fixed, not simply a need...

multipleOf less than 1 doesn't validate with `json_matches_schema`

Thanks, much appreciated!