John Biundo

Results 26 comments of John Biundo

@kamilmysliwiec: a few small suggestions, otherwise looks great!

@tristan957 Ah, I see you answered your question since I saw the notification. Cool 👍. Just for the sake of exchanging some learnings on this, if I understood your question,...

To my knowledge there are not yet any. I have been doing some editing of the Overview portion of the docs through a series of PRs over the last month...

So a SPA basically? I noticed in your code sample you're returning a user in the verify callback, and then maybe pulling off the authorization code param in the route?...

@kmturley Yeah, agreed. Those are the use cases that need to be documented.

@Feelthewind I think this is discussed in @nestjs/passport#57. There's a comment there that might help: https://github.com/nestjs/passport/issues/57#issuecomment-510610374

@Abrissirba This repo implements sessions with a similar pattern: https://github.com/johnbiundo/test-auth-chapter-sample

This article covers sessions in detail. Has been reviewed by the NestJS core team. https://dev.to/nestjs/authentication-and-sessions-for-mvc-apps-with-nestjs-55a4 I'll wait a few days to see if there are any further comments before closing.

@filipjnc Yeah, I do think it's worth adding something on sessions to the MVC chapter perhaps.

@TrejGun Sorry, I'm not clear on what the issue is. Can you clarify or provide a sample repo?