John Belamaric
John Belamaric
That said there I no issues with CoreDNS sending events. Just wanted to clear up the intended use of events in Kubernetes.
Could plugins implement a `ReloadRequestor` interface that contains a single `reloadNeeded` function? Then, in addition to the Corefile checks it does now, the `reload` plugin would check with all implementers...
Perhaps this would be better in the `rewrite` plugin or as its own plugin?
Awesome. One question. I am not looking at the code so maybe this is a nonsense question. But: > The collection of metadata functions from each plugin used to be...
Two questions: 1) What else is in 1.9.4, any critical bug fixes? 2) Does this change introduce regression risk (specifically when it is *not* being used)?
I am ok with either option.
Well, I think similarly to how you are displaying "Default" last I looked. I think there would be a few tiers: 1. Imported from a trusted source, like upstream Caddy...
/reopen /lgtm