John Bartholomew

When building with `-tags binary_log` to enable CBOR format output, the `ConsoleWriter` implementation *mostly* still works; it converts the CBOR data to JSON and formats it as normal. However it...

Report jest-junit testsuite errors as failures

2

Test errors are different (represented differently in the JUnit XML output from jest-junit) to test failures. Failures are tests which ran and failed, errors are for tests/test suites which did...

Upgrade Rapid YAML to v0.5.0, and switch to the single file amalgamation

1

Rapid YAML has an extensive CMake based build, which is probably ok but may be awkward to use from our other build systems (e.g., Bazel, which we probably want to...

Reformat everything (all C and C++ code) and enable format checks in GitHub workflow

1

This touches ~everything by reformatting with clang-format on all .cpp and .h files (by running `make reformat`). And then enables the format checks in the GitHub workflow, to detect regressions....

While trying to reproduce #1147 I hit this assert/check-fail (building with Makefile at cb18fec3721375ddfc938cb4831835ec06c64d81) ``` ❯ ./jsonnet -e 'std.parseYaml("1\n---")' third_party/rapidyaml/ryml_all.hpp:22998:check failed: !m_tree->is_stream(id) Aborted (core dumped) ``` ``` (gdb) bt #0...

Rewrite manifestJson to execute "stacklessly" inside evaluate()

1

This gets rid of the mutual recursion between `manifestJson` and `evaluate`, turning the `manifestJson` processing into a part of the interpreter's main loop. It should remove one avenue for native...