John Schnake

Results 148 comments of John Schnake

Seems like this would be helpful to me. I haven't looked the details in a while so my only concern would be whether or not there could be complications due...

@jpmcb Great list! One remark/question I had was regarding: > lifecycle/needs-proposal: For large features / bugs that need a proposal and community buy in My initial reaction was that I'd...

I remember having to do this to a CLI I worked on a few years ago and we were doing the update ourselves. By now there are more tools that...

Different implementations may differ about exit codes to use, presumably thats why its left out of the implementation. Just as easy as it would be to configure a field `ExitCodeOnError=1`...

Hi @Jarvvski , thanks for the ticket. What would you recommend adding to the README? I wouldn't be against it if it was something that added value, but my concern...

Is there an issue for this? Also, I noticed in the implementation that you call the `preRunE` then `preRun`; this is a bit different than the other `xyzE` methods since...

I'll wait 24hr to see if anyone else wants review or modify the nit. Otherwise I'll merge next time I see revisit.

This seems like a better approach to me as well. People do tend to code/script around these sorts of things so I'm slightly curious if it would be a breaking...

The exported method itself shouldn't be breaking unless I'm misunderstanding something. @jpmcb if he removes the addition to the method and just exports the method, is this good to merge?