John Stilley

Add some logic so HexAssemblies are hexagonal

1

Right now, the classes `HexAssembly` and `CartesianAssembly` are just empty slates: https://github.com/terrapower/armi/blob/8b9873cfe9df8dac6a26b28a7520c45b65fa3a50/armi/reactor/assemblies.py#L1229-L1237 https://github.com/terrapower/armi/blob/8b9873cfe9df8dac6a26b28a7520c45b65fa3a50/armi/reactor/assemblies.py#L1240-L1241 But they give people the assumption they can trust these assemblies have a shape, or the blocks...

Explore: Block.createHomogenizedCopy should raise a NotImplementedError

1

In the class `HexBlock` we have a method `createHomogenizedCopy()` that works. But in the base class `Block` we have the same method, but all it does is return a copy...

I believe this method has gotten kind of stale, and needs some love: https://github.com/terrapower/armi/blob/e2dba79a4e68c23a0dd06b90ea2e4cbaca335095/armi/reactor/composites.py#L1722 Some issues: 1. It only works if you call it on an `Assembly` or a `Core`,...

Tests are leaving crumbs

7

Last year I cleaned up all our unit tests so they don't pollute our working area with extra test files. BUT, it looks like several unit tests have been added/modified...

Right now, the settings validation tools are in the `operator` package, which is just strange: https://github.com/terrapower/armi/blob/6a546dd1ca3a81128e5dcc469a5d49853db2047c/armi/operators/settingsValidation.py#L44 But, we have a whole PACKAGE for settings. Surely this belongs there? **NOTE**: This...

I have several issues here: First, the `auto` should be upper case: https://github.com/terrapower/armi/blob/203f973f6affc9e081f540363792d205dc8976cf/armi/utils/flags.py#L32 Second, `flag.py` is under `armi/utils/`, but `flags.py` is under `armi/reactor/`. **NOTE**: I believe it is possible cleanup...

Remove Hex stuff from LatticePhysicsWriter

2

The very generic `LatticePhysicsWriter` class has some references to hex-assembly-based reactor design: https://github.com/terrapower/armi/blob/9da65879499bda3b9f1e9829e3d9f935275eeaa7/armi/physics/neutronics/latticePhysics/latticePhysicsWriter.py#L114 This variable name is not generally applicable to ALL reactors, and we need to ditch this from...

ArmiObject has too much children logic

1

The difference between [ArmiObject](https://github.com/terrapower/armi/blob/753660d71f3777680d541ff5d042d2d71100f4a3/armi/reactor/composites.py#L266) and [Composite](https://github.com/terrapower/armi/blob/753660d71f3777680d541ff5d042d2d71100f4a3/armi/reactor/composites.py#L2588) is _supposed_ to be that `Composite`s have children. But ArmiObject has a ton of children-specific logic, that just doesn't belong there: https://github.com/terrapower/armi/blob/753660d71f3777680d541ff5d042d2d71100f4a3/armi/reactor/composites.py#L582 https://github.com/terrapower/armi/blob/753660d71f3777680d541ff5d042d2d71100f4a3/armi/reactor/composites.py#L599 https://github.com/terrapower/armi/blob/753660d71f3777680d541ff5d042d2d71100f4a3/armi/reactor/composites.py#L1427...

There are too many (hex) assembly-specific tools in Core

1

The `Core` class in ARMI is meant to be useful to represent all reactor cores: https://github.com/terrapower/armi/blob/f580e3fe2120f93a0fbb0b5daa8424c9394c4698/armi/reactor/reactors.py#L226 But there are several major items in this class for assembly-based reactors: https://github.com/terrapower/armi/blob/f580e3fe2120f93a0fbb0b5daa8424c9394c4698/armi/reactor/reactors.py#L418 https://github.com/terrapower/armi/blob/f580e3fe2120f93a0fbb0b5daa8424c9394c4698/armi/reactor/reactors.py#L479...

Force Parameters to have descriptions

5

When constructing a `Parameter` object, we already have multiple checks to ensure the `Parameter` is valid: https://github.com/terrapower/armi/blob/59388d29f8929178e0e1aa4d8f0f160095a2b739/armi/reactor/parameters/parameterDefinitions.py#L250-L253 Why not add some to ensure there is a valid `description` field? I...