armi
armi copied to clipboard
Composite.calcTotalParam needs some TLC
I believe this method has gotten kind of stale, and needs some love:
https://github.com/terrapower/armi/blob/e2dba79a4e68c23a0dd06b90ea2e4cbaca335095/armi/reactor/composites.py#L1722
Some issues:
- It only works if you call it on an
Assembly
or aCore
, but it is defined on the genericComposite
. - This method is used in a lot of places downstream, but I believe a few of the input parameters are never used by anyone. We should clean those out.
- This method needs to... at least, have a warning in the docstring that notes that not all params CAN be summed meaningfully.
- This method is kind of risky. Not all parameters can be meaningfully summed. And the user has to KNOW.
- The code itself also needs a little TLC, this naming convention is pretty whiffy:
https://github.com/terrapower/armi/blob/e2dba79a4e68c23a0dd06b90ea2e4cbaca335095/armi/reactor/composites.py#L1783