John-Paul Smith
John-Paul Smith
Thanks very much for your review. I've pushed another commit incorporating these changes.
I tried various methods: - Downloaded directly from the GitHub releases page using a browser - Downloaded from the GitHub releases page using `curl` - `curl -sL https://sentry.io/get-cli/ | INSTALL_DIR=....
Right. My first thought was that it might be a resource exhaustion issue (max open files or similar), and in fact I did see a diagnostic message that sentry-cli had...
Thanks for reviewing this Phil, my comments are below. > * this is all host-side. Is there any desire for a plugin to be able to request its inputs are...
I have revised the OCIO properties based on our previous discussions, so that they now address a wider range of use cases. Notably: - kOfxImageEffectPropSupportsOCIO is provided on the host...
> However kOfxImageEffectPropOCIOConfig is set on the effect instance, but kOfxImageClipPropOCIOPreferredColourspace says it's set on a clip descriptor (i.e. at clipDefine time) not in a clip instance. Hopefully that's just...
Thankfully, OCIO 2.2 and ACES have already solved this problem for us. Two ACES configs are built in, and there is an API around built-in colourspaces which means that any...
Right, I am redoing the strings to be less OCIO-centric and will update the PR.
Sorry for the commit mess, I will clean this up now.
The latest changes should be OK to review now. In short, I reworked the properties to provide two alternative colour management styles based on the built-in ACES configs from OCIO...