Johannes Millan

Results 422 comments of Johannes Millan

Thanks for opening this up. This is less of a bug than an improve I'd say :) Though I personally don't need this adjustment, a PR would be welcome. EDIT:...

Not yet. But if somebody wants to add it, I am all for it. Should be mostly straightforward to implement.

I don't need the feature. So you would have to make a PR yourself I'm afraid.

You should find all the relevant code here: https://github.com/johannesjo/angular-material-css-vars/tree/master/projects/material-css-vars/src/lib The relevant material part can be found here: node_modules/@angular/material/_theming.scss You would need to play around with passing css variables instead of...

Hey there! Thanks for opening this up. You're most likely right, but for now I am pretty ok with the situation and the lib as it is, so I won't...

@Jrubzjeknf thank you very much for digging into this. You are probably much more familiar with the subject, than I am. What do you think would be the best/cleanest &...

That's great. Thank you very much! I am alright with making breaking changes if it is a solid solution and if I understand the issue correctly it might should have...

Hello @gotwig! I haven't tried this for myself nor I am very familiar with the official approach of component styling (and I never really saw the appeal to be honest),...

Hey there! Thank you very much for opening this up. Im personally not using any custom theme mixins in my projects and I am very very busy with my other...