Johanan Liebermann

Results 166 comments of Johanan Liebermann
trafficstars

Thanks for filing the issue @anton-johansson :slightly_smiling_face: The use case is clear to me. I'll share my thoughts regarding possible solutions: Introducing an API to handle failovers doesn't sound like...

I'd keep this one open since #630 doesn't deal with forcing failover. https://github.com/metallb/metallb/issues/704 is also related by the way.

On Packet, each server gets a `/31` CIDR. The even address is a virtual interface on the ToR switch and the odd address is the server. The even address is...

We are currently in contact with Packet regarding the possibility of having the [Packet CCM](https://github.com/packethost/packet-ccm) enrich `Node` objects with annotations. Such annotations could include node-specific BGP information which would alleviate...

I've looked into this a bit more and think we could actually support *both* options (labels and annotations) since the code for handling one or the other is practically identical....

A quick update on my end: the feature (called "peer autodiscovery") is largely implemented and I'm currently fixing bugs and increasing the test coverage while at it. Following is a...

I agree nicely-chopped commits makes things nicer and easier. As I've written above, though, I happen to have not been very orderly in the case of this PR (sorry). If...

I'm working on rebasing and re-organizing the commits to make them easier to review. In the meantime I'd love to get some feedback about the functionality. I've taken the time...

@daxmc99 have you tried the steps I wrote in the instructions? Assuming you did and something failed, could you share some info on the issue/error?

Cool. Happy to help if you get stuck, and welcome any feedback on the functionality and/or implementation.