Johan Andrén

Results 347 comments of Johan Andrén

Lookin' good! Needs some mima filters for internal constructors that changed signatures, then I think this is ready for merge.

Ah, I thought _that is_ how adapt is implemented in the behavior testkit, must have remembered wrong. I agree that sounds like it makes sense to improve (separately from this...

Given that it is a recommendation to stay away from `PlayServiceCall` and there are scenarios that now (1.6) no longer works with it I think it should be either deprecated...

Guessing there is something left here given that it was pushed across previous milestones

https://travis-ci.com/github/akka/akka-samples/jobs/473692192

https://github.com/akka/akka-samples/runs/4117600399?check_suite_focus=true#step:9:539

You could potentially use the TelemetrySpi for that (but note that we do not promise source or binary compatibility for that internal API) https://github.com/akka/akka-http/blob/90b5ecbc6f41b13af02153f3f61accb0458cf88e/akka-http-core/src/main/scala/akka/http/impl/engine/http2/TelemetrySpi.scala#L59

There is a PR in progress which adds `max-connection-keep-alive-time`.

When we fix this, would it be possible to also sneak in the peer ip in the warning/info message?