akka-samples icon indicating copy to clipboard operation
akka-samples copied to clipboard

alternate ShoppingCart based on ORMultiMap (#44)

Open johanandren opened this issue 7 years ago • 8 comments

Same as PR #55 but against the 2.5 branch

johanandren avatar Jun 15 '18 07:06 johanandren

Failed due to some infra issue. Can you please rebuild?

gosubpl avatar Aug 30 '18 06:08 gosubpl

Triggered

johanandren avatar Aug 30 '18 06:08 johanandren

Refs #44

johanandren avatar Aug 30 '18 06:08 johanandren

I'm afraid travis is having a bad day today: https://www.traviscistatus.com/

johanandren avatar Aug 30 '18 07:08 johanandren

I was quite surprised to see this closed. @raboof how can I help to get it into mergeable state again? Will you guys accept a TLA+ proof ? How to restructure code to make it more palatable? Maybe some fresh look from @helena ? Btw. I think this is a reasonable implementation, following a pattern from the BLOOM paper and not suffering the race condition of LWWMap that seems to be behind this failure: https://github.com/akka/akka-samples/issues/31 .

gosubpl avatar Jun 18 '19 19:06 gosubpl

Sorry, given that there were no replies to my comments in october and december last year I assumed there was no more interest in this PR, happy to reopen!

raboof avatar Jun 18 '19 19:06 raboof

Many thanks @patriknw for looking into that. I will refresh the code (thanks for the tips) and supply some explanatory content.

gosubpl avatar Jun 19 '19 13:06 gosubpl

Retargeted to 2.6 in case this is picked up again.

johanandren avatar May 04 '20 09:05 johanandren