johanadivare

Results 37 comments of johanadivare

Fixed with https://github.com/Haehnchen/idea-php-symfony2-plugin/blob/master/CHANGELOG.md#20221236

Well its good to have these 2 cases in testfixure

@staabm maybe you can give an example? And might still benefit rector as we also have [SimplifyEmptyArrayCheckRector](https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#simplifyemptyarraycheckrector) rule

I created https://github.com/rectorphp/rector-src/pull/3069 I did checkout the notes from @samsonasik https://github.com/rectorphp/rector/issues/7485#issuecomment-1251129232 but: note 1: I only check on ArrayType so if the type is nullable i dont replace it note...

As the docblock suggest: `$array = []; if(empty($values))', '$array = []; if([] === $values)` we check `[]` === `$values` Yoda style but the actual output will be `if($values === [])`....

Fixed with https://github.com/rectorphp/rector-symfony/pull/259

Also can confirm that `/img/volume_icon_ftp.png` is also not loading for me