johanadivare

it would look like this: https://getrector.org/demo/8bd44b67-1f32-4f36-b00a-d1b96a092506 But its says no changes while it is changing it for me like: ```php

@TomasVotruba that would be https://getrector.org/demo/285433df-5e9e-4b91-b766-2c4ff42de81a. And if i only tun this rule i would get same result as mentioned in https://github.com/rectorphp/rector-symfony/issues/229#issuecomment-1222313485 Thanks for quick reaction!

Ah good catch! But now my problem with https://getrector.org/demo/f261ad24-5764-4143-a6f4-ad78bc1fa34b is that there is still a `setDescription` i would expect a protected static property for it. Same case with the other...

I would expect something like: ```php

What do you mean with `So not sure how the upgrade path should look like`? The reason why i want the description to be a static property to make the...

Ah yeah, but would it not make sense to also move the description to static property to make it consistent with command name, and when it is a static property...

Yeah i can imagine then. It would look like the example off my comment in https://github.com/rectorphp/rector-symfony/issues/229#issuecomment-1222433331 and like i mentioned there it could make sense to remove function `configure` as...

@TomasVotruba can you have a look at my comment when you have time https://github.com/rectorphp/rector-symfony/issues/229#issuecomment-1225238668

Ah i created the issue from my work account closed it.

@samsonasik am i allowed to extend the rule: `SimplifyEmptyArrayCheckRector` https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#simplifyemptyarraycheckrector as it describes what i also want only changes the fact to check on `in_array()` and checking on types `array`...