johan-gson

Results 40 comments of johan-gson

@haowang-bioinfo @mihai-sysbio Could someone of you review this so I can merge it? It is a small change that makes it possible to run ftINIT properly for Mouse-GEM and similar...

Hi Mihail! Although you have a point, I request that we keep it as it is :) The main reason is that we otherwise break the interface, which for example...

I think you have a point, when I think of it the main concern would be that there is a substantial risk that people now will use the mouse model...

So, they should use it with Mouse-GEM, and with that reactions.tsv, although it probably doesn't matter. But using the right model is important.

> looks good - except that it suppose to be started from `develop` rather than a PR in draft, better change this @johan-gson I had to do that, I needed...

> Great job! I've left some aesthetic comments. > > In terms of the bigger picture, what is the aim here? To be able to run this once, now and...

> > I had to do that, I needed the code from that PR before it was approved. We did like this often in GECKO3. I'm thinking we can do...

Very nice, @mihai-sysbio, I had not seen this before. It solves the problem!

The downside of such an approach is that we will get many copies of some parts of the code, one for each organism, which will generate much more code to...

I agree that it would be good to keep a standard structure per base model, where we place the files etc. Maybe I just misunderstood you altogether :)