Harshith Mente
Harshith Mente
@yurishkuro Is this issue resolved or can i take it up?
> I would start with deleting internal/metrics/expvar and then making sure `make build-binaries-(your platform)` is ok. Yeah, i removed them and made sure the build is okay.
@yurishkuro can you review these changes and let me know if i've got to change any more?
> please make sure `make lint test` are green  Yeah, fixed them. Thanks for the help! Is there anything i need to change?
> You need to query Prometheus endpoint on each binary before and after changes to make sure no changes to metrics names happen. Yeah, I'll verify this once.
@yurishkuro I've resolved all the edits, thank you for helping me out. Absolutely sorry for messing up the namespaces. Can you please let me know if there's anything more i...
> I still see breaking changes. You need to test that the metrics names are the same, by running each of the main Jaeger components from your branch and from...
I'd like to take this up, Thanks!
this is a draft in process, would love to see if im going in the right direction or not.
> @joeyyy09 check the linter failures `kafkareceiver/unmarshaler.go:61: File is not `gci`-ed with --skip-generated -s standard -s default -s prefix(github.com/open-telemetry/opentelemetry-collector-contrib) (gci)` My bad, fixed that.