Joey Baker
Joey Baker
@jseminck changes made. I'd be happy to look at sharing code between this rule and `no-direct-mutation-state`, but I suggest we do that in a separate PR that focuses on improving...
@ljharb I appreciate you taking a look. I'm sure you're busy, but I'd like to work with you to get this merged. I believe it's a nice feature. At the...
@ljharb okay, I've added an option for `allowArrayMutation`, but I'd love more clarification on when the static `Object` methods would ever be okay.
Interesting. A few questions: 1. Why `enableInstanceMethods` over `allowArrayMutation`? "Instance methods" seem a little vague to me. 2. Why bother with the separate arrays and booleans? Seems like if you...
Fair enough on the config option. Will change. I really don't see the value in accommodating people who override the language builtins. Adding a config option will make the documentation...
@ljharb options added, and all feedback addressed!
@ljharb Okay, `Reflect` mutations added. Where do we stand?
@ljharb 👋
I'm unsure of who else to ping, so @yannickcr @jseminck @jackyho112 what are your thoughts on https://github.com/yannickcr/eslint-plugin-react/pull/1416#discussion_r139571616
@ljharb okay, options have been changed up and lodash methods removed. We now have just a `disabledMethods` option instead of 2 separate settings for each of `Object` and `Reflect`. @yannickcr...