Joey Baker comments

Results 43 comments of


                                            Joey Baker

Catch put errors

Wow – thanks! Everything you say makes sense. :+1:

feature request: async derived properties

You bet: ``` js … derived: { // current behavior mySyncProperty: { deps: ['aProp'] , fn: function deriveMySyncProperty(){ return this.aProp + 1 // mySyncProperty now set } } // proposed...

feature request: async derived properties

I would vote "yes" for a second `change` event. As you say, it's expected behavior that every time the state changes, we get a "change" event. That wouldn't be a...

feature request: async derived properties

@HenrikJoreteg the only downside with the current approach is that you have to manually add change even listeners to run the `calculateDrivingDistance` method. The nice part about derived properties is...

feature request: async derived properties

IMHO, leaving `model.drivingDistance` as `undefined` is okay. If we were to hook things up manually, that's what would happen.

feature request: async derived properties

I like @chesles suggestion of a `async: true` option. That would make the async derived properties explicit.

Change default config filename from "thrill.js" to "thrillConfig.js"

FWIW, Grunt opted for "Gruntfile.js". I mention it only because the `file` suffix is easier to type than `Config`.

Add no-mutation-props

Once this is in a good place, it's probably a good idea to use the same logic in the `no-direct-mutation-state` rule.

Add no-mutation-props

Yea, `++` and `--` are good calls. Can do. I'd love to share code between this and `no-direct-mutation-state`. Perhaps the way to do that is to add `isPropsNode` and the...