Joe Davies

Results 16 comments of Joe Davies

This can be seen in the [leaflet-gridviz demo](https://eurostat.github.io/leaflet-gridviz/examples/demo.html)

The fifth requirement states: _This pull request has a title in the format Add Name of List. It should not contain the word Awesome_ However, the title of this pull...

It seems you also missed this: _To verify that you've read all the guidelines, please comment on your pull request with just the word unicorn._ 🦄

- Your list was created on the 11th July 2023, it is not 30 days old yet. - You did not comment on either of the PRs you claim to...

> Stylistically, it's great. One thing to tweak up a bit though, after every title, you have a short description of what's to come, but you end all of those...

@lunohodov This was very helpful. Thank you very much.

For some reason... ```javascript CanvasRenderingContext2D.drawImage() ``` ...updates the canvas during desktop pan events, but not on mobile. https://github.com/eurostat/gridviz/blob/4fed3151b460f355b2f2528012e48ea709cb1838/src/GeoCanvas.js#L218 I've tried to fix it but no luck so far. I will...

these appear to be due to the fact that chrome recognizes 12 as a font size when using .style("font-size",12), but it should in fact be .style("font-size","12px")

could be achieved by setting the following d3 locale: d3.formatDefaultLocale({ "decimal": ",", "thousands": " ", "grouping": [3], "currency": ["", "€"] }) then using d3.format(",.2r") to format the strings