Johannes Theiner

Results 739 comments of Johannes Theiner

[this.component = new Header({](https://github.com/Ordeeper/obsidian-journaling-plugin/blob/db3157293c1218282c77c5a7d41aa2a973c0c9eb/src/settings.ts#L19-L21) This should not be at the top of the settings, below the settings would be better [containerEl.createEl("h4", { text: "General Settings" });](https://github.com/Ordeeper/obsidian-journaling-plugin/blob/db3157293c1218282c77c5a7d41aa2a973c0c9eb/src/settings.ts#L23) [Don't add a top-level...

[api](https://github.com/lazerfit/korean-book-search/blob/fe8bafac573e70e982861f65705101884b4fe16e/main.ts#L132), [Api](https://github.com/lazerfit/korean-book-search/blob/fe8bafac573e70e982861f65705101884b4fe16e/main.ts#L134), [api](https://github.com/lazerfit/korean-book-search/blob/fe8bafac573e70e982861f65705101884b4fe16e/main.ts#L135) [new Setting(containerEl).setName('🚀Aladin api key setup').setHeading();](https://github.com/lazerfit/korean-book-search/blob/fe8bafac573e70e982861f65705101884b4fe16e/main.ts#L132), [new Setting(containerEl).setName('🧩 Default frontmatter fields').setHeading();](https://github.com/lazerfit/korean-book-search/blob/fe8bafac573e70e982861f65705101884b4fe16e/main.ts#L157) Only use headings if you have more than one setting per section. [const fronmatterData = formatFrontmatterData(bookInfo, custom,...

[.setting-item textarea {](https://github.com/onikun94/obsidian-local-rss/blob/6f3589c9fe705bbf38dee0ab8cc26273dff1fbb8/styles.css#L11-L17) Please don't overwrite core styling in a plugin, add another class/data attribute so it only applies to your plugin. [.setName('フィード名')](https://github.com/onikun94/obsidian-local-rss/blob/6f3589c9fe705bbf38dee0ab8cc26273dff1fbb8/main.ts#L494), [.setName('フィードURL')](https://github.com/onikun94/obsidian-local-rss/blob/6f3589c9fe705bbf38dee0ab8cc26273dff1fbb8/main.ts#L501), [.setName('カスタムフォルダ名(オプション)')](https://github.com/onikun94/obsidian-local-rss/blob/6f3589c9fe705bbf38dee0ab8cc26273dff1fbb8/main.ts#L508-L509) This is missing localization. [new...

[new Setting(containerEl).setName('🚀 Default setting').setHeading();](https://github.com/lazerfit/korean-book-search/blob/9a2955d36a4a14359fadcc8d631f2b8c3b06bf95/main.ts#L136) [Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Only+use+headings+under+settings+if+you+have+more+than+one+section.)

[# obsidian-navigator-api](https://github.com/wilsonangara/obsidian-navigator-api/blob/71f008f29f2e8fefb9417a86b82e3663a8691201/README.md#L1) Naming something "Obsidian xyz" is reserved for first party products we create, please change this header. ["description": "This plugin provides a way to navigate through the Obsidian Vault...

Resetting the review bot because the Git history rewrite caused a few issues.

You need to fix the things pointed out by the review bot first. After that I will review. Only then will this PR be merged.

Ignore the merge conflicts, they will be handled when the PR is merged.

[# Obsidian PicBedUploader Plugin](https://github.com/YumeAyai/obsidian-picbeduploader/blob/c3851c70868818567c33b33980007dcceb0a7d35/README.md#L1) Naming something "Obsidian xyz" is reserved for first party products we create, please change this header. [uploadEndpoint: "https://example.com/upload",](https://github.com/YumeAyai/obsidian-picbeduploader/blob/c3851c70868818567c33b33980007dcceb0a7d35/main.ts#L11) This should be empty by default, in the...

[Copyright (c) 2023 Juanjo Arranz](https://github.com/Erallie/css-inserter/blob/b104c5dc55d3a97214c181061f64a5e7434fca1d/LICENSE.txt#L3) Update this, but keep the original copyright. ["author": "Erika Gozar",](https://github.com/Erallie/css-inserter/blob/b104c5dc55d3a97214c181061f64a5e7434fca1d/manifest.json#L7) Also credit the original author here. [containerEl.createEl('span', { text: 'A fork of ', cls: 'instructions'...