joerg1985
joerg1985
@kaikreuzer Okay it looks like there might be issues, but as long as the user has to opt-in via the `org.openhab.core.common.SequentialScheduledExecutorService` system property everything should be fine. In some years...
@kaikreuzer you are right, this will protect from trouble.
@kaikreuzer i just updated the PR, the flag is gone and the review should be easier now.
@kaikreuzer is there any thing left that i need to do, before this can be merged? Just asking, because i have some time the next days.
@morph166955 the current plan is to opt-in via a system property to avoid general issues. Regarding the congestion of the pool, this PR uses a unlimited pool, in the worst...
@kaikreuzer thank you for the review, i addressed most of these points. There are two open points with questions how to continue.
@kaikreuzer now all the points are addressed, so i think this is ready :rocket:
@kaikreuzer yes, this is correct. To enable the new executor the pool size must be set > 0, this allows to enable it only for specific pools.
@lolodomo no, i am currently testing (and fixing https://github.com/openhab/openhab-core/pull/4247). As soon as there is a stable version, i will write to the Milestone topic to find more testers. Do you...
This might be a nice place to add some of these flags: https://github.com/openhab/openhabian/blob/65cbf0d8819941e539520db780844e057832ebc5/functions/openhab.bash#L221-L228