joerg1985
joerg1985
I think it would be nice to unsubscribe from single events. The `BiDi` has a `public void clearListener(Event event) {` which is missing for the `DevTools`. So are there any...
@jhalterman could you have a look at this PR? It is a small change so it should be a easy review. Thanks in advance
One potential issue the `Automatic-Module-Name: dev.failsafe` in `failsafe-3.3.2.jar` does not match the actual module name `dev.failsafe.core`. And the `failsafe-okhttp-3.3.2.jar` has the same `Automatic-Module-Name: dev.failsafe`.
Sorry i did not look too deep into this before opening, the encoding is correct. The title of this issue should be: "status" could be removed from error responses. e.g....
The `DriverServiceSessionFactory` is not closing the `HttpClient` when the session fails to start, will fix this the next days.
https://github.com/SeleniumHQ/selenium/commit/97d56d04e1b4ab4f8e527f8849b777c1e91d13f7 is the promised commit @IlyaUk could you update to the next nightly and check?
@IlyaUk @EvgenyMarchuk i have done some fixed related releasing the websocket in https://github.com/SeleniumHQ/selenium/commit/ed3edee0ac4f09a5555aec7c7ab20609d8b394f2, https://github.com/SeleniumHQ/selenium/commit/5bac4795ff6acc9f1ca1a6436aea0970ff98fb07 and https://github.com/SeleniumHQ/selenium/commit/7612405e34d282992b26a22d7bee921753020026. I hope the leak is gone now, could you check this?
@IlyaUk from todays log the revision is `7c8727b`, this revision is the same you tested 3 weeks ago. You might have used a cached version of the `selenium/hub:nightly` image?
The current [nightly](https://github.com/SeleniumHQ/selenium/releases/tag/nightly) is https://github.com/SeleniumHQ/selenium/commit/58ca1331ab8671090f2cdb05c17a9af54841523e Or you could try 4.24.0, this release is brand new and contains the fixes.
@IlyaUk thanks for reporting and testing the fix.