Joel Ostblom
Joel Ostblom
Thank you for going through and reverting the style on all of these examples before merging @dangotbanned !
> I linked the wrong release-drafter. This one has the [autolabeler](https://github.com/pola-rs/polars/blob/884b2acd5fc44fd59f4eaa38558680f58e7bb11e/.github/release-drafter.yml#L12) Thanks for updating that, I was confused initially when looking for the labeling part. I think including this autolabeler...
Yup, that should be all that is needed. You can see a few more options and examples [in the GitHub docs in case it's helpful.](https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes#configuration-options)
I ran the update steps locally and it seems to work fine. I can put up a PR and I'm happy to add anyone as a maintainer who wants to...
Super, thank you @MarcoGorelli ! I put up the altair PR referencing yours for Narwhals https://github.com/pyodide/pyodide/pull/5124
Closing this since https://github.com/pyodide/pyodide/pull/5124 was merged
> Would you rename that class or just move it to a new submodule and still import it in the top-level? My hope was to move it to a submodule...
Based on the helpful reply in https://github.com/microsoft/pylance-release/discussions/3709#discussioncomment-5093960 it seems like we need to get https://github.com/altair-viz/altair/pull/2614 or similar merged, but maybe it is worthwhile if it resolves some of the VS...
Thanks for the suggestion @dangotbanned. Ideally we would avoid introducing an additional object that we need to complete from and have just `x='col_name'`. As @binste mentioned, it would be great...
This would be useful! I think ctrl + enter could be a good candidate for submit since it is used elsewhere (such as github and gmail) and would also work...