Joel Ostblom

Results 591 comments of Joel Ostblom

> I'd support switching over fully if there was no loss of functionality. I'm also on board with this

I'll let @kanitw chime in with more details about the previous PR, but I'm curious about the use case for having `yOffset` without `y` encoding as in your example. Is...

I would be in favor of that too if it is an easy fix

I tested with the notebook (6.4.11, both in Firefox and Chrome) and additional tab presses currently offer little value to the completion experience as they just seem to refresh the...

@ellisonbg Just a ping on this. Would love to hear your thoughts on my last video comparing the classic notebook tab completion behavior with with that in jlab, and my...

Thank you for the detailed reply and providing all that context @krassowski ! > I was suggesting removing the partial prefix insertion on second tab because as of today it...

Looks great! The location for the callout seems suitable to me. The only thing I would add is that I think we should include an example in the user guide...

@dangotbanned I noticed that you tagged me for review here, but also that the PR is still marked as draft, so I just want to double check whether you want...

While reviewing https://github.com/vega/altair/pull/3544/commits/50a520e9314108d572ef8bd6d48f0135151d2c6c, I got some ideas for rearranging sections on this page to make it easier to follow. I have most of it done and will finish it off...

@dangotbanned Sorry for the delay here. I wanted to go in an revert the examples to the old syntax, but I've been buried in work lately =/ I don't want...