Antoine Estienne
Antoine Estienne
Sounds good, I will take at the compatibility layer. Thanks!
@jacogr I'm back on this issue. So if I understand correctly, I need to copy `https://github.com/polkadot-js/extension/blob/master/packages/extension-dapp/src/compat/singleSource.ts` to adapt injected metamask web3 to conform to the right interface. Is there any...
Hi @jacogr , did you get the occasion to look at the code? Thanks in advance
Hi @jacogr So I pushed some changes on https://github.com/polkadot-js/extension/pull/566 First off, I want to say that the singleSource has probably not been tested because the initCompat function was never called....
Thanks for the help. So I was able to display the address on polkadot-js/extension#566 but only with a small modififcation on the ui-keyring (https://github.com/polkadot-js/ui/pull/413) I was not able to get...
## Summary of the current state of MetaMask integration into apps: ### Now - accounts are injected successfully and display with correct balance - when implementing signRaw with the eth_sign...
https://docs.metamask.io/guide/signing-data.html#a-brief-history https://github.com/ethereum/go-ethereum/pull/2940 personal_sign does prepend data with "\x19Ethereum Signed Message:\n" + len(message). and signTypedData is even worse because it requires the data to be in a json-like format
I was able to make a test proving that MetaMask still supports eth_sign without the prefix : https://github.com/joelamouche/test-dapp/tree/testEthSign So I'm resuming the effort to integrate MetaMask https://github.com/polkadot-js/common/pull/969 (ready) https://github.com/polkadot-js/extension/pull/566 (wip)...
@jacogr Great news! Metamask integration was tested with a simple transfer! All PRs are ready but maybe apps should be merged last (see description)
@albertov19 ready to be tested again