Joe Hand

Results 148 comments of Joe Hand

It's a bit easier to review if you just push a new commit rather than squishing all the changes. I forget what I was commenting on last time, so nice...

Looks good if you can just move that test over to test it on sharing. 🎉

Oh wow I read this as *hidden folders* not *empty folders*. Ignore me. ~This is a "feature" not a bug =). You can pass the --no-ignoreHidden option to import hidden...

Hmm, yes that may be a separate issue. But if its showing up on Datbase, it seems like it'd in the metadata - we may just have to fix it...

> I just created a private dat share, and I havn't told anyone, or anything about that dat:// - and the connection count changes between 0 and 1, and the...

> In a "get me data" container, it'd be good to have a more transactional log format. 👍

:+1: want to do a PR =)

> Should we be pooling hypercore instances instead of creating them with .get() every time? Ya, we could definitely optimize the get to not create them every time. Seems like...

I realized this also skips the email whitelist, which wasn't intended but I think that makes sense.

Hashbase went to #1 I think as did hypercore-archiver. Code here is just a bit behind both.