dat-node icon indicating copy to clipboard operation
dat-node copied to clipboard

Allow for specification of dat secret storage directory.

Open brandonedens opened this issue 6 years ago • 5 comments

brandonedens avatar Mar 08 '18 05:03 brandonedens

Thanks! I moved the secret keys to an option in the second argument. Can you update this PR to reflect that? Should make it a bit simpler =).

It'd be great to have a test for this as well! Please also make sure you run npm test on your machine and the syntax is all okay.

joehand avatar Mar 08 '18 17:03 joehand

Codecov Report

Merging #193 into master will decrease coverage by 0.45%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
- Coverage   84.86%   84.41%   -0.46%     
==========================================
  Files           7        7              
  Lines         304      308       +4     
==========================================
+ Hits          258      260       +2     
- Misses         46       48       +2
Impacted Files Coverage Δ
index.js 100% <ø> (ø) :arrow_up:
lib/storage.js 68% <50%> (-3.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20e7353...3a18e96. Read the comment docs.

codecov-io avatar Mar 09 '18 04:03 codecov-io

Are the tests passing locally for you? Look like they are hanging on travis but not sure why.

joehand avatar Mar 12 '18 21:03 joehand

It's a bit easier to review if you just push a new commit rather than squishing all the changes. I forget what I was commenting on last time, so nice to see the diff =)

joehand avatar Mar 19 '18 20:03 joehand

Looks good if you can just move that test over to test it on sharing. 🎉

joehand avatar Mar 19 '18 20:03 joehand