joegoldman2

Results 43 comments of joegoldman2

Is there a need to support several versions of Semantic Conventions in parallel? If not, why not version the package with the same version number as Semantic Conventions (1.25, 1.26,...

> Re-checking - Can two http methods have the same route values?. if that happens, we will incorrectly set the display name here. Right, so the cache key should take...

I'm not sure what to do with this PR considering the benchmark result. Any suggestion?

There is no need to force consumers to migrate to .NET 9. Microsoft.Bcl.Memory is compatible with .NET Standard 2.0.

Yes, we just need to upgrade it and use the provided Base64Url implementation. There is no need to update the target framework of Fido2 lib.

> The fido MDS repo is built with the expectation that developers should cache the response. > > If we can adress that in the default scenario, I think this...

Similar timeout hit in #115959: ``` System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.SyncHttpHandler_HttpClientHandlerTest.GetAsync_SecureAndNonSecureIPBasedUri_CorrectlyFormatted', Elapsed: 00:06:44 System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.SyncHttpHandler_HttpClientHandlerTest.GetAsync_SecureAndNonSecureIPBasedUri_CorrectlyFormatted', Elapsed: 00:08:44 System.Net.Http.Functional.Tests: [Long Running Test] 'System.Net.Http.Functional.Tests.SyncHttpHandler_HttpClientHandlerTest.GetAsync_SecureAndNonSecureIPBasedUri_CorrectlyFormatted', Elapsed: 00:10:44 System.Net.Http.Functional.Tests: [Long Running...

@martincostello with dotnet/runtime#116269 and dotnet/runtime#115959 available in .NET 10, the HttpClient native instrumentation now records exceptions. I think you can condition the following lines to apply them only for versions...

For each I can check the difference and keep the inherited documentation if it is more specific. Would you accept a PR per project for example?

Considering all PRs that have been merged about XML docs, I think we can close this issue.