joegoldman2

Results 43 comments of joegoldman2

I understand and yes I had to cast to double (especially in the OpenTelemetry exporter) which means a loss of precision. For financial or scientific applications it's quite common and...

I think it could be something feasible and could be the solution for now. As OTLP doesn't support more precision for the moment, I let you decide if you want...

> * there is no standard way to get container name. It should be provided by customer - most probably on constructor. We may try to use some environment variable...

> And user can do it already, using OTEL_RESOURCE_ATTRIBUTES environment variable. With this approach, the pod name and container name will be part of the Resource (as it's quite common...

@iskiselev I'm not really sure what to do next? Do you want to initiate a new discussion in opentelemetry-specification about new environment variables?

Ok, so I guess the next step is to define the desired API to allow users to set the values programmatically, right?

Thank you for the API proposal https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/1699#issuecomment-2164160848. What is the procedure to review/validate a new API?

The header `Correlation-Context` is not added by the OTel SDK but by the runtime in `HttpHandlerDiagnosticListener`. https://github.com/dotnet/runtime/blob/81adb342a98566244207106700678e838ea23645/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/HttpHandlerDiagnosticListener.cs#L646 https://github.com/dotnet/runtime/issues/45496 is tracking the replacement of this header by `baggage`. But for the...

By default, ASP.NET Core uses `LegacyPropagator` which supports the extraction from `baggage` header with a fallback to `Correlation-Context`. https://github.com/dotnet/runtime/blob/49c10ed5d96375d563d5202c71ca39a0fab3618e/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/LegacyPropagator.cs#L63

No plan for the moment. I'm ready to help but I would need some insights about the next steps and what should be done.