Joe Elliott

Results 268 comments of Joe Elliott

We were seeing similar issues. Our error is: ``` panic: invalid Go type model.TraceID for field jaeger.api_v2.SpanRef.trace_id [recovered] panic: invalid Go type model.TraceID for field jaeger.api_v2.SpanRef.trace_id ``` For us issues...

In Tempo the querier is responsible for inspecting the backend to find the trace. If you have questions about it, it would make more sense to discuss in that repo.

Very cool! If you are looking for a trace id do you pull each db independently and search them? Are you coordinating parallelism somehow or do you do it one...

+1 We will personally not be able to move to OTEL clients until they support remote sampling, but I think starting this migration is the right choice.

I like this improvement, but I think we need to mention the change in the readme. It may impact other deploys. Also, as discussed in the [issue](https://github.com/grafana/tempo/issues/1621) linked above, how...

I like the idea of adding the default security context. Should we do that in a different PR? or does it make sense along with these changes?

I am good on this change. @rlex I appreciate your passion for security. This is not the first PR/issue you've filed where you've pushed for best practices in Tempo. @zanhsieh...

Heads up that I'm about to merge this and you will need to update your chart version. Thanks! https://github.com/grafana/helm-charts/pull/1699