joe-blocher

Maybe you can implement, like the 'ghost-admin-api-session': versions/5.54.4/core/server/services/auth/session/express-session.js ``` function getExpressSessionMiddleware() { ... name: 'ghost-admin-api-session', cookie: { maxAge: constants.SIX_MONTH_MS, httpOnly: true, path: urlUtils.getSubdir() + '/ghost', sameSite: urlUtils.isSSL(config.get('url')) ? 'none' :...

In core/frontend/apps/private-blogging/lib/middleware.js: ´´´ const privateBlogging = { … return session({ name: 'ghost-private', maxAge: constants.ONE_MONTH_MS, signed: false, // sameSite: 'none'

I have made the PR

It's nearly three month later ... an nothing happened. But for me it closed, because I'm working locally :-) https://forum.ghost.org/t/make-this-site-private-not-working/39938

I have made my first PR. I think the 2. one failed: Merge branch 'main' into joe-blocher-patch-1 I don't really know what is for and how I can delete this...

**You did't fix the error: Make this site private - not working not working in Chrome and Opera**  ...

The pull request still not merged in version 5.82.2: [Fixed private mode cookie for local development #17938](https://github.com/TryGhost/Ghost/pull/17938) Why not?

I've downloaded the code: versions/5.82.2/core/frontend/apps/private-blogging/lib/middleware.js But the code is still the same: `return session({ name: 'ghost-private', maxAge: constants.ONE_MONTH_MS, signed: false, sameSite: 'none'

> > The code being the same does not mean your PR was not merged. In this case it looks like this change ended up possibly breaking something else so...

**Downloaded version 5.89.1 - this bug still not fixed** You have to change only 2 lines in your code. The first time I reported the solution in August 2023. Why...