Joe Ayoub

Results 132 comments of Joe Ayoub

Hi @alecbatch , I reviewed the PR, but there were too many design issues with it so I ended up creating another branch and refactoring the code. You can see...

Hi @alecbatch just following up on this. Have you had a look at the internal PR I created here? https://github.com/segmentio/action-destinations/pull/2995

Hi @alecbatch. I reviewed the PR - seems fine apart from the unit test. I can't really comment on if the performBatch() and perform() functions work. Did you send some...

hi @alecbatch Are you interested in completing this Integration? I think we only have some minor items to wrap up before I deploy it. If you'd like to do this...

Moved to https://github.com/segmentio/action-destinations/pull/3127

Hi @ManikMM - I'll provide feedback on this PR in the next 24h.

Closed - moved to https://github.com/segmentio/action-destinations/pull/2919

hi @cyberlord29 please ping me directly when this PR is ready for review.

hi @sayan-das-in - would you be able to review the core change in this PR please? I'm not concerned about the Destination specific code so you can ignore that -...

I've asked @brennan to include this PR in the same deploy as this [other core change](https://github.com/segmentio/action-destinations/pull/2325) (so that it can be monitored more closely)