action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

Add oauth2 for webhook2.0

Open cyberlord29 opened this issue 1 year ago • 1 comments

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.

  • [ ] Added unit tests for new functionality
  • [ ] Tested end-to-end using the local server
  • [ ] [Segmenters] Tested in the staging environment

cyberlord29 avatar Aug 26 '24 07:08 cyberlord29

hi @cyberlord29 please ping me directly when this PR is ready for review.

joe-ayoub-segment avatar Aug 26 '24 08:08 joe-ayoub-segment

Codecov Report

Attention: Patch coverage is 63.88889% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (5a5f52b) to head (78251a8). Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
.../src/destinations/webhook-extensible/send/index.ts 44.44% 8 Missing and 2 partials :warning:
...tions/src/destinations/webhook-extensible/index.ts 66.66% 2 Missing :warning:
packages/core/src/destination-kit/action.ts 50.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2334       +/-   ##
===========================================
+ Coverage   33.18%   78.98%   +45.79%     
===========================================
  Files          14     1210     +1196     
  Lines         693    21954    +21261     
  Branches      109     4448     +4339     
===========================================
+ Hits          230    17340    +17110     
- Misses        463     3542     +3079     
- Partials        0     1072     +1072     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 30 '24 13:09 codecov[bot]

hi @sayan-das-in - would you be able to review the core change in this PR please? I'm not concerned about the Destination specific code so you can ignore that - but there is a core change in Destination Kit which I'd like someone experienced to review.

@cyberlord29 is keen to get this out today if possible.

edit: I can see that the folks in India are OOO today. So unfortunately this PR will have to wait.

joe-ayoub-segment avatar Oct 02 '24 09:10 joe-ayoub-segment

I've asked @brennan to include this PR in the same deploy as this other core change (so that it can be monitored more closely)

joe-ayoub-segment avatar Oct 08 '24 11:10 joe-ayoub-segment