Jochen Jonckheere

Results 14 comments of Jochen Jonckheere

In MVC Render is used without @Html, it is @RenderBody() and @RenderSection(...), a logical syntax for Knapsack would be: @RenderStyles() @RenderScripts() @RenderScripts(location: "body") or @RenderBodyScripts() But this is only possible...

I agree with @eholman, it should be optional to have the JsonConverter attribute added or not. And if possible to use the JsonStringEnumMemberConvertor from the [Macross.Json.Extensions](https://github.com/Macross-Software/core/blob/develop/ClassLibraries/Macross.Json.Extensions/README.md) or other custom one.

@mukrop can we borough a little bit of your time to see if #61 is the fix for #46? Maybe just approving 2 PRs and creating a release could help...

> Hi. I've tested the patch, but the issue is not fixed, the error seems the same. > ``` > /usr/lib/ruby/2.7.0/uri/rfc3986_parser.rb:21:in `split': URI must be ascii only (URI::InvalidURIError) > ```...

@mukrop you can choose how to merge everything. None of the PRs are mine. 😉

Funny, I thought you where the repo owner. 🤔

@keithmifsud are you able to merge this PR and create a new release?

@keithmifsud any luck on removing Travis CI check?

It is probably caused by the spread operator in: https://github.com/rx-angular/rx-angular/blob/e12e32eeca851bc1029fdd55a314eadf67ef5531/libs/cdk/transformations/src/lib/array/update.ts#L107 Maybe it can be replaced by an Object.Assign instead, like this: ```typescript x.push(match ? Object.assign(existingItem, match) : existingItem); ``` The...

@SeanFarrow will it be something like this library: https://github.com/gowon/HealthChecks.OpenTelemetry.Instrumentation?