Jocelyn Thode

I can confirm that I have exactly the same issues as @rickie95 . Using any of the themes here I was never prompted for the password. I have to press...

@codergr : Were you able to use macvlan in a swarm with services ? Can you easily change the scope of a network ?

@annablender Hey! Let me know if I can improve something in the PR or if you need something else before someone can review it! :)

@paynejacob Hey could anyone review this PR please?

Hey @annablender Thanks for giving this PR a look. It's been a long time but if I remember correctly I basically used an AdmissionConfiguration file and reverse engineered from there....

@HarrisonWAffel: I tried adding unit tests. This made me modify my code a bit especially the return types and the parameters of my functions. However now I get the following...

Testing it in my repo I get: ``` panic: interface conversion: interface {} is map[string]interface {}, not []map[string]interface {} goroutine 146 [running]: github.com/rancher/terraform-provider-rancher2/rancher2.expandClusterRKEConfigServicesKubeAPIAdmissionConfigurationPlugins({0xc000a48760?, 0xc001215b90?, 0x1f24afb?}) /home/jocelyn/Liip/terraform-provider-rancher2/rancher2/structure_cluster_rke_config_services_kube_api.go:268 +0x4b1 github.com/rancher/terraform-provider-rancher2/rancher2.expandClusterRKEConfigServicesKubeAPIAdmissionConfiguration({0xc000fc6720, 0x1, 0x1f4372a?})...

@HarrisonWAffel: Thanks! Your explanation was clear and I was able to fix my issue! I should have thought about digging into the provider code, my bad!

@HarrisonWAffel I have fixed the code as you suggested.

@annablender done thanks for the example!