Joaquim Rocha
Joaquim Rocha
Let's add a confirmation step to the drain option.
@farodin91 Sorry I clicked the Ready for Review button by mistake. Let me know if this is actually ready to be reviewed so I take a look. I agree that...
> @joaquimrocha This is now rebased. I will try to take a look tomorrow. Thanks.
> @joaquimrocha Any feedback? Sorry. Completely dropped the ball on this one. I had checked the code and it looked fine. I have tested now which is what I still...
> @joaquimrocha Should we fix this in different PR? To be honest, the UX looks pretty broken with it. So if we merge, we wouldn't be able to release like...
Hey @farodin91 . Sorry it took me a bit to get to review the update. Can you rebase the branch so I can try it again?
I tried the changes locally and they LGTM. Please rebase and we will merge it.
@ashu8912 Maybe this has to do with #1591 .
@yolossn , any thoughts on this?
@dioniseo , sorry to hear that. We'll definitely look into that issue next week. Would it be helpful if there was a way to disable certain plugins using a configuration...