headlamp
headlamp copied to clipboard
headlamp-k8s
frontend: Include LimitRange and ResourceQuota on Namespace Details
based on #1611
From workflow perspective, it could be interesting to see ResourceQuotas and LimitRanges per Namespace. As they are mainly for all stuff inside the namespace.
What does anyone think?
@farodin91 Sorry I clicked the Ready for Review button by mistake. Let me know if this is actually ready to be reviewed so I take a look. I agree that having the ResourceQuotas and LimitRanges is good (and I think it's what kubectl does too, rigth?).
@joaquimrocha This is now rebased.
I will try to take a look tomorrow. Thanks.
@joaquimrocha Any feedback?
Sorry. Completely dropped the ball on this one.
I had checked the code and it looked fine. I have tested now which is what I still had to do, and the only problem is that the table search filter is not designed to happen multiple times in one view. So the result is that if we use the search filter, it changes the state for all the tables in that view:
We should fix the filter by allowing individual searches per table, instead of the global redux-based one.
@joaquimrocha Should we fix this in different PR?
To be honest, the UX looks pretty broken with it. So if we merge, we wouldn't be able to release like this. We could however merge if we hide the search filter all along (because then we get a missing feature, rather than a broken one 😉 ).
Hey @farodin91 . Sorry it took me a bit to get to review the update. Can you rebase the branch so I can try it again?
I tried the changes locally and they LGTM. Please rebase and we will merge it.