João Pedro Magalhães

Results 53 comments of João Pedro Magalhães

How about an API like ``` ``` To make this work we can rely on `React.Children` to render the parts in the right place

> I've updated the PR to make the mentioned API working. I'm using it in production like that It's kind of weird passing `Command` props in `Command.DialogPortal`. How about extracting...

Hi @louisgv and @brattonross, I played around a bit trying to get this to work and managed to prune unused colors and apply opacity modifiers to the colors, but the...

Hey @natac13, how are you doing the exit animation?

With tailwind, just use `data-*` modifier: `data-[state=open]:animate-show data-[state=closed]:animate-hide` https://codesandbox.io/p/sandbox/pedantic-aryabhata-1ykgmk?file=%2FApp.jsx

@its-monotype @sanvishal Using tailwind-animate seems to work for me https://codesandbox.io/p/sandbox/busy-noether-9ew9u2?file=%2FApp.jsx About the `onAnimationEnd` not firing on close, it's a issue https://github.com/radix-ui/primitives/issues/1020

@its-monotype Yes, I updated the example with tailwind-animate to look like the one in tailwind.config

@charlesBochet `onOpenChange` is only triggered when the state is updated internally by Radix

> This will allow the popup to close now, but does not solve closing the dialog when clicking outside of the popup. > > I think these changes should be...

> > > This will allow the popup to close now, but does not solve closing the dialog when clicking outside of the popup. > > > I think these...