Johannes Wagner

Results 16 comments of Johannes Wagner

could I also have a copy the patch please?

already dropped you a message on your webpage: johannes punkt wagner und gmail punkt com

So what I'm unsure about is what the return value should be in case of NaN. Should it be 0 or 'unavailable' or none? In the PR I opted for...

> You have a CI problem, please solve that. yes will do

> please run the tests locally, so you don’t call a review before the code works. I did and they pass. The failure is at `Set up Python 3.10`: `Error:...

polite question, is something missing from my side for a revised review?

> A polite answer you have not answered my last review comments…and if I remember right your doc. PR also have issues (I might remember wrong ), it is marked...

> Just controlled there are 6 review comments without response. You might have solved all 6 in the commits you made, but how do you expect me to know that...

> @janiversen Those comments in your review screenshots, have the `pending` badge: > > ![image](https://user-images.githubusercontent.com/195327/235294186-dceaf928-7f46-4cfe-ba4c-422818e86a58.png) > > Meaning you still need to submit them as a review. You are the...

> Any progress on this, there are a number of open review comments and it is out of date with the dev branch. > > In case of no progress...