Joakim Erdfelt

Results 489 comments of Joakim Erdfelt

> I think it is either @priority (if available) or useless (if you know which container you want you do new MyContainer(), no?). The use of `MyContainer()` is supported by...

@rmannibucau this is great detail, thank you. Lots to noodle through here. I just am cautious about making the API even messier than it already is. Example: If I could...

Then there is the issue with merging decoders in common between the annotations and configuration. It could be argued that just like `@ServerEndpoint(value="/echo")` is overridden if using `ServerEndpointConfig.getPath()`, why wouldn't...

> I don't think the API will need to change (but haven't thought about this much) I agree. This seems like a need for updated documentation and/or javadoc, along with...

@volosied In the original example ... ``` java ServerEndpointConfig.Builder.create(PurchaseEndpoint.class, "/floo") ``` The `PurchaseEndpoint.class` has an annotation defining the the decoders. Then when you use the `ServerEndpointConfig.Builder.create(class, ....)` you have the...

> How about this then: > > * EndpointConfig Encoders/Decoders are in addition to those configured via Annotation > * EndpointConfig Encoders/Decoders take priority over those configured via Annotation >...

We need to be careful about the order of the resulting set of encoders / decoders when we have these new rules.

> > Are we going to have the primitive decoders in the WebSocket spec too? > > Do you mean to allow users to override the platform primitive types decoders?...

> Is the typical user expectation with the current API that EndpointConfig Encoders/Decoders are in addition to those configured via Annotation or that they replace them? The current Javadoc suggests...

I would like to think that what is declared in your annotations is unconnected to what is available on the container. So declaring, for example, "permessage-deflate" means you would like...