Joakim Erdfelt
Joakim Erdfelt
Current list in `jetty-9.4.x` (not including tests) ``` jetty-continuation/src/main/java/org/eclipse/jetty/continuation/FauxContinuation.java:404: long expireAt = System.currentTimeMillis() + _timeoutMs; jetty-continuation/src/main/java/org/eclipse/jetty/continuation/FauxContinuation.java:416: wait = expireAt - System.currentTimeMillis(); jetty-deploy/src/main/java/org/eclipse/jetty/deploy/DeploymentManager.java:124: this.stateTimestamps.put(node, Long.valueOf(System.currentTimeMillis())); jetty-gcloud/jetty-gcloud-session-manager/src/main/java/org/eclipse/jetty/gcloud/session/GCloudSessionDataStore.java:532: long now = System.currentTimeMillis(); jetty-gcloud/jetty-gcloud-session-manager/src/main/java/org/eclipse/jetty/gcloud/session/GCloudSessionDataStore.java:626:...
A PMD rule to check for `System.currentTimeMillis()` could be created. Each occurrence would need to be vetted. Either changed or PMD tagged as appropriate (via a comment before its use).
@olamy are you going to make that commit (on your branch) a PR?
@sbordet old jetty-client API question.
At a minimum, the `FirewalledResponse` should be aware of the value on `HttpServletResponse.isCommitted()` not attempt to do anything if that returns true (indicating the response is committed and no header...
I went ahead and added unit testing for the `10.0.x` (256a5a163e024db8b8e0118ac2d606ce2dd919ab) and `11.0.x` (416c2cc3e4e694f32a57d9f44f68863d61022568) branches. It works as expected. Even tested the websocket server with the browser's own javascript client...
Be accurate, and detailed please. > I am connecting phone device by websocket to control it. Phone device are the clients. what phones? what is the websocket client on those...
> I tried with springboot- websocket, no issues but only in jetty facing the issue This doesn't tell me anything I can work with. We still don't even know what...
If the client is sending that, they are in violation of the WebSocket spec AND the HTTP spec at the same time. ``` Pragma: no-cache Cache-Control: no-cache ``` Those 2...
> I'm not sure how we can support both Jetty 9 and Jetty 11 in the same module since the jetty-server artifact has not changed coordinates. We don't want to...