Joseph Musser

Results 575 comments of Joseph Musser

One thing https://github.com/nunit/nunit.analyzers could explore is using a diagnostic suppressor automatically for the first dereference of `expr` following `Assert.That(expr, Is.Not.Null);` and `Assert.NotNull(expr);` when not inside a multiple assert block. It...

Another option is to use https://www.nuget.org/packages/Shouldly. I've been using it in all my NUnit test projects for a couple of years, and I added full nullability annotations in the recently-released...

@manfred-brands The team decided at https://github.com/nunit/nunit/issues/3473#issuecomment-592254847 that we cannot add that constraint to Assert.NotNull because Assert.NotNull does not always throw when it fails due to the multiple asserts feature. I...

A point I'd like to add is that the BCL and C# language designers do not see getting rid of `!` as a goal. It's intended to be used often...

@Parshudar Hello! We'd be happy for the help. Let us know if you're still interested and we'll assign to you.

I like the idea. Like you point out, https://docs.microsoft.com/en-us/dotnet/api/system.memoryextensions.sequenceequal doesn't determine the failure point, but I wonder if there's another API that would. It's only available in .NET Standard 2.1...

I think we should try to make this work. It could be a tricky call-nesting problem in NUnit's execution. It might make sense to do this together with https://github.com/nunit/nunit/issues/4012#issuecomment-983106320.

I like everything you listed! I have some more thoughts about NUnit.Core but that deserves its own thread probably. What do you think about supporting either `net472` or `net48` long-term?...

Even though the feature was complete in C# 10, generic attributes can only be used by setting `preview` for a while since they break so much tooling. I haven't heard...

> - Improved async support. It would be great not to do async-over-sync in assertions, or possibly at TestMethodCommand level either @stevenaw https://github.com/nunit/nunit/issues/2843 is relevant.