John Newbery
John Newbery
> I have uploaded an initial implementation of the YubiKey to the TestFlight (version 0.13.0 (2)). > > Setup process: > > 1. Settings -> PGP Key: select YubiKey >...
This is based on a 2018 base commit. Needs to be rebased to pick up all of the new tests/changes since then.
Code looks safe, but should be rebased on a recent base commit to ensure all new tests/checks run successfully. Should https://github.com/bitcoin/bips/blob/master/bip-0009.mediawiki#getblocktemplate-changes be updated to say that `maxversion` no longer has...
Concept ACK on making this consistent. I'll review once you have an updated proposal that addresses gmaxwell's input.
I agree with @gmaxwell's suggestion here: https://github.com/bitcoin/bitcoin/pull/19825#issuecomment-683372477 that we shouldn't try to do any clever logic. I think the behaviour should be: - for `setban add`: - Convert the IP...
My view: yes, this should be part of webln. One reason is that the application can know in advance how much to ask for in an allowance. For your example...
Code review ACK 6d75df749d
reACK 8af5283992
utACK 70595a585483539b19e3fe77f07e32d06063266b Verified git range-diff
> So, what happened? The relaytxes and minfeefilter fields were always present, and documented as such, in the output of the getpeerinfo RPC. This isn't true. **None** of the fields...